Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] Add auto sync for WTF-Solidity and WTF-Ethers #191

Merged
merged 13 commits into from
Jun 24, 2024
Merged

[Feat] Add auto sync for WTF-Solidity and WTF-Ethers #191

merged 13 commits into from
Jun 24, 2024

Conversation

jes16jupyter
Copy link
Contributor

@jes16jupyter jes16jupyter commented Jun 10, 2024 •
edited
Loading

  1. Rename Doc Folders
  2. Change Sync.json sync.sh and add sync-meta.py

@vercel Vercel
Copy link

vercel bot commented Jun 10, 2024

@github-actions[bot] is attempting to deploy a commit to the WTF Team on Vercel.

A member of the Team first needs to authorize it.

@jes16jupyter jes16jupyter changed the title [Feat] Add auto sync for WTF-Solidity and WTF-Ethers [WIP-Feat] Add auto sync for WTF-Solidity and WTF-Ethers Jun 10, 2024
@jes16jupyter jes16jupyter changed the title [WIP-Feat] Add auto sync for WTF-Solidity and WTF-Ethers [Feat] Add auto sync for WTF-Solidity and WTF-Ethers Jun 10, 2024
@jes16jupyter
Copy link
Contributor Author

Hi @AmazingAng Could you plz take a look? You can switch to this branch, and just call source sync.sh.

@AmazingAng
Copy link
Member

@chongqiangchen pls review

@jes16jupyter
Copy link
Contributor Author

@AmazingAng

@AmazingAng
Copy link
Member

得让后端看下这样重命名有没有影响

@chongqiangchen
Copy link
Collaborator

chongqiangchen commented Jun 14, 2024 •
edited
Loading

@jes16jupyter
或许可以考虑减少对sync.sh插入特定仓库的处理代码，这里看起来或许可以把sync-meta.py改造成执行的方案为：python3 sync-meta.py docs/solidity-101，然后将这个作为scripts插入到sync.json？

@chongqiangchen
Copy link
Collaborator

得让后端看下这样重命名有没有影响

这个不会有影响

@chongqiangchen chongqiangchen self-assigned this Jun 14, 2024
@chongqiangchen chongqiangchen self-requested a review June 14, 2024 06:18
@jes16jupyter
Copy link
Contributor Author

@chongqiangchen 就这个吗，其他还需要修改吗？

@jes16jupyter
Copy link
Contributor Author

@jes16jupyter 或许可以考虑减少对sync.sh插入特定仓库的处理代码，这里看起来或许可以把sync-meta.py改造成执行的方案为：python3 sync-meta.py docs/solidity-101，然后将这个作为scripts插入到sync.json？

我觉得这个说的很好，我修改一下，避免侵入性

@chongqiangchen
Copy link
Collaborator

@chongqiangchen 就这个吗，其他还需要修改吗？

暂时看起来就这个~其他的感觉没啥问题

@jes16jupyter
Copy link
Contributor Author

jes16jupyter commented Jun 15, 2024 via email

@jes16jupyter
Copy link
Contributor Author

@AmazingAng @chongqiangchen Fixed. Plz check

@jes16jupyter
Copy link
Contributor Author

@chongqiangchen Hi, could you plz take a look~

@chongqiangchen
Copy link
Collaborator

chongqiangchen commented Jun 20, 2024 via email

@chongqiangchen chongqiangchen merged commit 1821b4e into WTFAcademy:main Jun 24, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chongqiangchen chongqiangchen Awaiting requested review from chongqiangchen

Assignees

@chongqiangchen chongqiangchen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jes16jupyter @AmazingAng @chongqiangchen